Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Try to set the monospace font size up to six times in SpyderApplication (Utils) #22826

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • This prevents Spyder to get stuck in an infinite loop for monospace fonts that don't have an xHeight that matches the app font one in a close range of sizes around the app font size.
  • Also, add block comments to that class to make the code more readable and make the method used to set the monospace font private.

Issue(s) Resolved

Fixes #22661.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

This prevents Spyder to get stuck in an infinite loop for monospace
fonts that don't have an xHeight that matches the app font one in a
close range of sizes around the app font size.
Also, make _set_monospace_interface_font private because it's not used
publicly.
@ccordoba12 ccordoba12 added this to the v6.0.3 milestone Nov 3, 2024
@ccordoba12 ccordoba12 self-assigned this Nov 3, 2024
@ccordoba12 ccordoba12 merged commit ffe3fe5 into spyder-ide:master Nov 3, 2024
17 checks passed
@ccordoba12 ccordoba12 deleted the issue-22661 branch November 3, 2024 18:01
@ccordoba12
Copy link
Member Author

@meeseeksdev please backport to 6.x

meeseeksmachine pushed a commit to meeseeksmachine/spyder that referenced this pull request Nov 3, 2024
…up to six times in `SpyderApplication` (Utils)
ccordoba12 pushed a commit that referenced this pull request Nov 3, 2024
…ize up to six times in `SpyderApplication` (Utils)) (#22829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spyder 6 stuck when computing xHeight of monospace font
1 participant