PR: Fix FoldingPanel._expand_selection to not select text an extra line below a folded region (Editor)
#23044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @athompson673! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-21 16:07:04 UTC |
ccordoba12
changed the title
FoldingPanel._expand_selection to not select text on extra line below a folded region (Editor)
ccordoba12
changed the title
FoldingPanel._expand_selection to not select text on extra line below a folded region (Editor)FoldingPanel._expand_selection to not select text on extra line below a folded region (Editor)
ccordoba12
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Tested locally and it works like a charm. Thanks @athompson673!
ccordoba12
changed the title
FoldingPanel._expand_selection to not select text on extra line below a folded region (Editor)FoldingPanel._expand_selection to not select text an extra line below a folded region (Editor)
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Nov 21, 2024
…` to not select text an extra line below a folded region (Editor)
ccordoba12
pushed a commit
that referenced
this pull request
Nov 21, 2024
…tion` to not select text an extra line below a folded region (Editor)) (#23046)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Edited
FoldingPanel._expand_selection+1fromend_line)MoveOperation.NextBlockso blank line is not left after deleting folded portionIssue(s) Resolved
Fixes #23042
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: athompson673