PR: A couple of fixes for the Internal console #23217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the right parent and style for the completion widget in the console.
- Before we were initializing SpyderShortcutsMixin in PythonShellWidget, but that changed some attributes of other ShellBaseWidget mixins (e.g. it made SaveHistoryMixin.history_filename empty). - However, moving SpyderShortcutsMixin to ShellBaseWidget and initializing it before other mixins fixes that problem.
|
@meeseeksdev please backport to 6.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/spyder
that referenced
this pull request
Dec 8, 2024
ccordoba12
pushed a commit
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
InternalShell. This sets the right parent and style for the completion widget in the console (regression introduced in PR: Improve the way command line options are handled by plugins #17657).Issue(s) Resolved
Fixes #23196.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: