Fix Nuitka cross compilation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for raising this. Honestly, I didn't even realize this code existed. I don't like what it's doing. Frame hacks/debuggers probably don't belong in library code, in my opinion, and I think my intention will be to remove it entirely in a future version. In the meantime, I'm happy to accept your patch. It may take me a bit of time to review this fully, so thank you in advance for your patience. |
|
Thanks for reviewing ;) |
spyoungtech
added a commit
that referenced
this pull request
Jul 25, 2024
Gh 27 fix nuitka cross compilation
|
Thanks. I merged this into a separate branch so that the pre-commit service hook had premissions to auto-apply fixes and was subsequently merged to main in #29 and is released in v5.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes Nuitka cross compilation of FreeSimpleGUI from RHEL to Ubuntu targets.
See netinvent/npbackup#62 for more details