-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Emscripten 3.1.64 #589
Conversation
3.1.52 no longer allows using .bc, so use .o instead. Using .a throws "Unknown format, not a static library!".
v3.1.55 removed the --memory-init-file option, and this caused the build to fail with "emcc: error: --memory-init-file is no longer supported". Fixed by removing the option from Makefile.
While testing this with the devcontainer, I bumped into puppeteer/puppeteer#12833 which I workarounded with diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index ce6189c..072317b 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -20,7 +20,7 @@
// Use 'postCreateCommand' to run commands after the container is created.
// We use `npm ci` instead of `npm install` because we want to respect the lockfile and ONLY the lockfile.
// That way, our devcontainer is more reproducible. --Taytay
- "postCreateCommand": "npm ci",
+ "postCreateCommand": "PUPPETEER_DOWNLOAD_BASE_URL=https://storage.googleapis.com/chrome-for-testing-public npm ci",
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "node"
}
\ No newline at end of file with the proper fix being upgrading Puppeteer. Puppeteer's postinstall step still tries to download the correct version of Chrome so might as well delete the chrome installation from the devcontainer (although the |
Some warnings in CI:
I think these come from e.g.: https://github.com/emscripten-core/emscripten/blob/8c81cac1bbae378bc7dde0c21c99602cbaf452d0/src/library_legacy.js#L12-L16 will probably become an upgrade blocker at some point but not right now |
Thank you! |
This pull request broke the https://sql.js.org/dist/sql-wasm.wasm build |
It looks like the main branch's CI deploys the |
Ok, I'll make a new release on npm |
I updated puppeteer in 158dfb4 |
I just pushed v1.11.0 which is compatible with the wasm file from sql.js.org |
This PR upgrades Emscripten to 3.1.64 and fixes things caused by breaking Emscripten changes.
--memory-init-file
so removed from MakefileI don't have the capacity to do further testing other than just checking that the repo's
npm run test
passed, and don't have enough context about the repo to know what's breaking in the changelog so I'll just leave this work here in case it's useful.Closes #588