Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the direct passing of dictionary literals. #414

Closed
wants to merge 3 commits into from

Conversation

cocolato
Copy link
Contributor

Fix: #400 and #401

Support the direct passing of dictionary literals when calling functions and fix the errors caused by unexpected nested braces.

@cocolato
Copy link
Contributor Author

The regular expression used here might not be elegant, but there should be no problem in terms of functionality.

@zzzeek zzzeek requested a review from sqla-tester October 31, 2024 15:42
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision a08ff83 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change a08ff83: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5558

Copy link
Member

@zzzeek zzzeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more tests to add. obviously im nervous about this change since we have to keep reverting it.

test/test_lexer.py Show resolved Hide resolved
@cocolato
Copy link
Contributor Author

Sorry for the late reply. Now all the tests have passed.

@zzzeek zzzeek requested a review from sqla-tester November 11, 2024 17:50
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c6aa6be of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

Patchset c6aa6be added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5558

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5558 has been merged. Congratulations! :)

@zzzeek
Copy link
Member

zzzeek commented Dec 3, 2024

im going to release mako 1.3.7 now with these two changes you did, leaving enough room in the week to revert if we have more reports of issues, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how do you pass a dict as a parameter to <%namespace:def
3 participants