-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the direct passing of dictionary literals. #414
Conversation
e3b2708
to
43b6b89
Compare
43b6b89
to
a08ff83
Compare
The regular expression used here might not be elegant, but there should be no problem in terms of functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision a08ff83 of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change a08ff83: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more tests to add. obviously im nervous about this change since we have to keep reverting it.
Sorry for the late reply. Now all the tests have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c6aa6be of this pull request into gerrit so we can run tests and reviews and stuff
Patchset c6aa6be added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5558 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5558 has been merged. Congratulations! :) |
im going to release mako 1.3.7 now with these two changes you did, leaving enough room in the week to revert if we have more reports of issues, thanks! |
Fix: #400 and #401
Support the direct passing of dictionary literals when calling functions and fix the errors caused by unexpected nested braces.