Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major build updates 2023-01 #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jan 9, 2023

UPDATED:

supersedes PR #43; includes PR #42

TODO:

  • update targetSdkVersion -> 33 - I had some trouble with this, may need some investigation (looks like this was already done in master)

STATUS:

I would favor keeping this as a draft for now. Better if we can test without the SDK 31 updates, not everyone may be ready for this yet.

Now that this project targets recent SDK 33, I would favor this over the minor updates proposed in PR #43

@brodycj brodycj changed the title major build updates 2023-01 DRAFT: major build updates 2023-01 Jan 9, 2023
@brodycj brodycj marked this pull request as draft January 9, 2023 03:01
@brodycj
Copy link
Contributor Author

brodycj commented Jan 9, 2023

Looks like e113fa2 would be overridden by 2cf379d on master ... I would like to rebase the other changes

@brodycj brodycj changed the title DRAFT: major build updates 2023-01 major build updates 2023-01 Jan 10, 2023
@brodycj brodycj marked this pull request as ready for review January 10, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant