This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Fetch table columns & triggers #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxcnunes Seems everything's fine now :) |
| @@ -119,6 +121,16 @@ async function listRoutines(server, database) { | |||
| return database.connection.listRoutines(); | |||
| } | |||
|
|
|||
| async function listTableColumns(server, database, table) { | |||
There was a problem hiding this comment.
I guess need the async because of the https://github.com/BornaP/sqlectron-core/blob/13-fetch-table-columns/src/db/client.js#L172.
That throws an exception. I guess without the async it will not reject the promise properly.
Since that is the current pattern used for all functions in that file. I will accept without applying your suggestions. We can try out without async in another commit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR regarding issue #13 .
I implemented API for fetching table columns and triggers related to tables in Sqlectron. This can be consumed in GUI to load table columns on double clicking the table, or for (future) SQL editor autocomplete.
Since it's required in PostgreSQL to define (additional) trigger function to create a trigger, I had to change old db.spec.js a bit.
Code is tested for MySQL and PostgreSQL locally and all the tests are passing. For SQL Server I can not guarantee as I don't have it locally and don't use it regularly, so we will see when it runs on CI. What I noticed regarding SQL Server is that it does not have information_schema for triggers so I used sp_helptrigger.