AnySetOf grammar
#2326
Merged
AnySetOf grammar
#2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jpy-git/sqlfluff into create_table_references_grammar
jpy-git
commented
Jan 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #2326 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 159 159
Lines 11303 11313 +10
=========================================
+ Hits 11303 11313 +10
Continue to review full report at Codecov.
|
|
Will take a look at adding some additional tests for coverage tomorrow, the PR is otherwise passing though. |
barrywhart
approved these changes
Jan 17, 2022
| and (str(matched_option) in available_option_counter) | ||
| ): | ||
| available_option_counter[str(matched_option)] += 1 | ||
| # Check if we have matched an option too many times. |
There was a problem hiding this comment.
Could this be moved inside the if above? It may be possible to simplify the logic as well -- IIUC, we only need to check if matched_option has hit the maximum.
There was a problem hiding this comment.
@barrywhart good shout, I've simplified the logic by moving the if condition 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
Closes #2322. Adds
AnySetOfgrammar.AnySetOfis defined asMatch any number of the elements but each element can only be matched once.I've updated the grammar introduced in #2315 to use this new segment.
Happy to convert a couple places in the grammar/add extra tests if needed (this is my first time updating the parser code).
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.ymlrule test cases intest/fixtures/rules/std_rule_cases..sql/.ymlparser test cases intest/fixtures/dialects(note YML files can be auto generated withtox -e generate-fixture-yml).test/fixtures/linter/autofix.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.