Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres & MySQL: cleanup AliasExpressionSegment #2353

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Postgres & MySQL: cleanup AliasExpressionSegment #2353

merged 2 commits into from
Jan 19, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Jan 19, 2022

Brief summary of the change made

Makes progress on #1488.

The ANSI AliasExpressionSegment was updated in this commit to allow for some Exasol parsing (quoted literals for aliasing also applies to tsql and bigquery).
Postgres and MySQL are pretty basic in this regard and this ANSI segment is causing parsing issues in the linked issue so we can just overwrite them.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #2353 (409994e) into main (a50ccd8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          160       160           
  Lines        11383     11391    +8     
=========================================
+ Hits         11383     11391    +8     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_mysql.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50ccd8...409994e. Read the comment docs.

@jpy-git jpy-git merged commit 37a993f into sqlfluff:main Jan 19, 2022
@jpy-git jpy-git deleted the postgres_mysql_simplify_alias branch January 19, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants