Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L041: Fix duplicate DISTINCT corruption #2365

Merged
merged 2 commits into from
Jan 20, 2022
Merged

L041: Fix duplicate DISTINCT corruption #2365

merged 2 commits into from
Jan 20, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Jan 20, 2022

Brief summary of the change made

Closes #2363. Fixes the linked issue, and more generally simplifies, the rule logic using the functional API.

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice clean up.

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #2365 (eb99487) into main (c2b2c60) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #2365   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          161       161           
  Lines        11464     11464           
=========================================
  Hits         11464     11464           
Impacted Files Coverage Δ
src/sqlfluff/rules/L041.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b2c60...eb99487. Read the comment docs.

@jpy-git jpy-git merged commit b133141 into sqlfluff:main Jan 20, 2022
@jpy-git jpy-git deleted the l041_fix_duplicate_distinct branch January 20, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L041 multiplies DISTINCT
2 participants