-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exasol: Add lua adapter scripts (7.1+) #2801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a LUA test case to make sure it doesn’t regress in future?
Also no concerns of < 7.1 users not using that optional clause still? Or is it arguably best practice to include to anyway so happy to make non-optional?
Codecov Report
@@ Coverage Diff @@
## main #2801 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 163 163
Lines 12310 12309 -1
=========================================
- Hits 12310 12309 -1
Continue to review full report at Codecov.
|
Like I said, it's easy to fix when adding a language keyword (this is still the prefered way). I think that adapter scripts are rarely used so this should not have great impact. Furthermore I think that we should add support for the latest version since 7.0.x will be EOL in mid 2022.
I don't have a working test case since I don't used this functionallity before. There is no example in the docs. I will add a dummy one to make sure the parsing works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming all tests pass!
Brief summary of the change made
Allow lua adapter scripts which are introduced in 7.1. Furthermore I removed the
optional
flag for the script language definition since this is mandatory in 7.1+.Are there any other side effects of this change that we should be aware of?
May break scripts which not defined a language (<7.1). This could easy fixed by adding a script language parameter.
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.