-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparkSQL: Create Table Delta Lake Variant #2954
SparkSQL: Create Table Delta Lake Variant #2954
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2954 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 164 164
Lines 11852 11855 +3
=========================================
+ Hits 11852 11855 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SQL file was not parsed into YAML since it was in a subdirectory. I suggest removing using a naming convention instead of a subfolder:
test/fixtures/dialects/sparksql/delta_create_table.sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit which I'll commit now.
Brief summary of the change made
Adds additional segments to support Delta Lake
CREATE TABLE
syntaxAre there any other side effects of this change that we should be aware of?
Additional sub-directory in
test/fixtures/dialects/sparksql
for delta related tests. It contains an README and test cases for Delta syntax. I thought this would be easier for troubleshooting and if Delta is ever split into it's own dialect.Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.