Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkSQL: Create Table Delta Lake Variant #2954

Merged
merged 6 commits into from
Mar 31, 2022

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Mar 30, 2022

Brief summary of the change made

Adds additional segments to support Delta Lake CREATE TABLE syntax

Are there any other side effects of this change that we should be aware of?

Additional sub-directory in test/fixtures/dialects/sparksql for delta related tests. It contains an README and test cases for Delta syntax. I thought this would be easier for troubleshooting and if Delta is ever split into it's own dialect.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2954 (b7f0aa2) into main (b40eddf) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #2954   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines        11852     11855    +3     
=========================================
+ Hits         11852     11855    +3     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_sparksql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40eddf...b7f0aa2. Read the comment docs.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SQL file was not parsed into YAML since it was in a subdirectory. I suggest removing using a naming convention instead of a subfolder:

test/fixtures/dialects/sparksql/delta_create_table.sql

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit which I'll commit now.

src/sqlfluff/dialects/dialect_sparksql.py Outdated Show resolved Hide resolved
@tunetheweb tunetheweb merged commit c8d8607 into sqlfluff:main Mar 31, 2022
@R7L208 R7L208 deleted the r7l208/sparksql-delta-create-table branch August 30, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants