-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostgreSQL: added support for CREATE ROLE
and DROP ROLE
statements
#3010
Conversation
"""A `DROP ROLE` statement with CASCADE option. | ||
|
||
https://docs.exasol.com/sql/drop_role.htm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not got cascade in this version?
And also let's remove the Exasol link. Did you find it in coachroach docs? Maybe that one would be better as tends to be closer to ANSI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this. If you have the coachroach link then let's add it.
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Co-authored-by: Barry Pollard <barry_pollard@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## main #3010 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 164 164
Lines 11997 12001 +4
=========================================
+ Hits 11997 12001 +4
Continue to review full report at Codecov.
|
CREATE ROLE
and DROP ROLE
statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go now!
@tunetheweb Thank you for your support and explanation! Next time will be more accurate :) |
No probs. And sorry for just barging and taking over, rather than letting you resolve them, but looking to release 0.12.0 soon and wanted to get this included in that. |
Brief summary of the change made
fixes #2943
Are there any other side effects of this change that we should be aware of?
everything looks straightforward, so shouldn't be
Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.