Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of Compound Statements #3121

Merged

Conversation

jonyscathe
Copy link
Contributor

@jonyscathe jonyscathe commented Apr 20, 2022

Extra WITH statements could be associated with the compound statement.
Fixed by replacing match_grammar StartsWith and parse_grammar optional
Sequnce with a match_grammar Sequence.

Brief summary of the change made

Fixes #3092

Are there any other side effects of this change that we should be aware of?

None

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Extra WITH statements could be associated with the compound statement.
Fixed by replacing match_grammar StartsWith and parse_grammar optional
Sequnce with a match_grammar Sequence.
@tunetheweb tunetheweb changed the title fix: Adjust with_compound_statement Fix parsing of Compound Statements Apr 20, 2022
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming tests pass

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #3121 (355a0ea) into main (ddc3200) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          165       165           
  Lines        12267     12266    -1     
=========================================
- Hits         12267     12266    -1     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc3200...355a0ea. Read the comment docs.

@tunetheweb tunetheweb merged commit 7a3c2b4 into sqlfluff:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing issue with CTE in Materialized View
2 participants