Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Struct type should be a segment #3591

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Struct type should be a segment #3591

merged 2 commits into from
Jul 11, 2022

Conversation

alanmcruickshank
Copy link
Member

@alanmcruickshank alanmcruickshank commented Jul 11, 2022

Was initially part of #3428 but to required as part of new fix #3590.

I think this still makes sense - the other Struct-like things (e.g. TypelessStructSegment) are segments and StructTypeGrammar was the odd one out. This swaps StructTypeGrammar to instead be StructTypeSegment.

This also removes the unnecessary and unreferenced definition of StructKeywordSegment.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #3591 (445e76d) into main (f49122d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3591   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines        13206     13211    +5     
=========================================
+ Hits         13206     13211    +5     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <100.00%> (ø)
src/sqlfluff/dialects/dialect_bigquery.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49122d...445e76d. Read the comment docs.

@alanmcruickshank alanmcruickshank merged commit cab754e into main Jul 11, 2022
@alanmcruickshank alanmcruickshank deleted the ac/struct_segments branch July 11, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants