Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake - ALTER TABLE IF EXISTS and WHEN SYSTEM$STREAM_HAS_DATA() #3641

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

chrisalexeev
Copy link
Contributor

Brief summary of the change made

Added snowflake dialect support for the optional ALTER TABLE IF EXISTS... syntax as well as tasks that use the WHEN SYSTEM$STREAM_HAS_DATA() conditional.

Are there any other side effects of this change that we should be aware of?

No.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #3641 (39eb2a5) into main (ac852a2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3641   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          175       175           
  Lines        13294     13297    +3     
=========================================
+ Hits         13294     13297    +3     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac852a2...39eb2a5. Read the comment docs.

@tunetheweb tunetheweb changed the title Snowflake - ALTER TABLE IF EXISTS and WHEN SYSTEM$STREAM_HAS_DATA() Snowflake - ALTER TABLE IF EXISTS and WHEN SYSTEM$STREAM_HAS_DATA() Jul 20, 2022
@tunetheweb tunetheweb merged commit 2674982 into sqlfluff:main Jul 21, 2022
@chrisalexeev chrisalexeev deleted the snowflake_dialect_enhancements branch July 21, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants