Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparksql dialect to support lambda expressions (->) #3821

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

juhoautio
Copy link
Contributor

Brief summary of the change made

Implements #3373.

Credits to @cmotta for implementing the same for athena dialect in #3551 – it was easy to follow the approach taken there.

Are there any other side effects of this change that we should be aware of?

Nope

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #3821 (262f36a) into main (5200849) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3821   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines        13718     13719    +1     
=========================================
+ Hits         13718     13719    +1     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_sparksql.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@barrywhart barrywhart merged commit 01f3118 into sqlfluff:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants