Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation of user_rules in Linter #3977

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Oct 20, 2022

Brief summary of the change made

Fixes #3973

user_rules now correctly takes in any class inherited from BaseRule instead of expecting an instance of such a class.

This resolves some type errors arising from the wrong annotation in test/core/rules/rules_test.py.

Are there any other side effects of this change that we should be aware of?

N/A

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5a5231b) compared to base (121d6dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #3977   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        14433     14433           
=========================================
  Hits         14433     14433           
Impacted Files Coverage Δ
src/sqlfluff/core/linter/linter.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@barrywhart barrywhart merged commit e233d8a into sqlfluff:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotation for user_rules parameter of the Linter class is wrong
2 participants