-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4255 (Fix exception on mixed indent description) #4288
Conversation
Would we not want to fix a mixed indent? You'd expect a mixture of tabs and spaces to be wrong in any scenario - granted that'd be a more involved change |
We do - but that's a different rule. This is a rule aimed just at trailing/leading comments and doesn't include the logic to fix the indent. It's a good question on why someone would only want to do one and not the other - but I could imagine someone with a particularly strange indentation setup might want to use us to lint commas but not indents. 🤷 |
Pull Request Test Coverage Report for Build 3928982305
💛 - Coveralls |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 201 201
Lines 15181 15183 +2
=========================================
+ Hits 15181 15183 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This resolves #4255 . The problem arises from trying to make a description for a mixed indent, which we don't actually need. This resolves that gracefully by providing a generic "mixed indent" return so that things can complete nicely.