Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSQL: Add support For Clause #4501

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

AidanHarveyNelson
Copy link
Contributor

Brief summary of the change made

fixes #3772

Added additional support for the other data types specified in the FOR clause https://learn.microsoft.com/en-us/sql/t-sql/queries/select-for-clause-transact-sql?view=sql-server-ver16

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4401410693

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4398316081: 0.0%
Covered Lines: 17356
Relevant Lines: 17356

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d4c10c6) 100.00% compared to head (9dd7630) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4501   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          204       204           
  Lines        15524     15526    +2     
=========================================
+ Hits         15524     15526    +2     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_tsql_keywords.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_tsql.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@WittierDinosaur WittierDinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanmcruickshank alanmcruickshank added this pull request to the merge queue Mar 13, 2023
@alanmcruickshank alanmcruickshank removed this pull request from the merge queue due to the queue being cleared Mar 13, 2023
@alanmcruickshank alanmcruickshank added this pull request to the merge queue Mar 13, 2023
Merged via the queue into sqlfluff:main with commit c101fcf Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to Parse Valid T-SQL JSON Statement
4 participants