Sqlfluff - Refactor and update the extension #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parallel start overloading the cpu. Killing running process before running a new one. (cherry picked from commit dab6319)
RobertOstermann
force-pushed
the
sqlfluff
branch
from
02661d9
to
32885d3
Compare
|
@dorzey - would you be able to review this one? I'm afraid it's far beyond my JS-Fu. |
|
@RobertOstermann - if he's not able to review then I'll do my best in a few days time. Thanks for taking the time to put this together 🙏 |
tunetheweb
suggested changes
Jul 12, 2022
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
…cuteInTerminal is true
|
@tunetheweb I have made the changes you requested. I also noticed a few more problems when looking through my code and testing the extension. I have fixed those issues in recent commits. |
Show notifications for templating/parsing errors. Default sqlfluff.ignoreParsing to false. Use the workingDirectory setting with the linter. Make process.ts a static class.
RobertOstermann
force-pushed
the
sqlfluff
branch
from
abe4c89
to
342db8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the changes from my
sqlfluff extendedextension.