Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #50

Closed
accforgithubtest opened this issue Aug 7, 2023 · 3 comments
Closed

Dark Mode #50

accforgithubtest opened this issue Aug 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@accforgithubtest
Copy link

Loving this project !

Are there any plans to support Dark Mode in UI ?
I think having dark mode will be a killer feature.

Thanks !

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 7, 2023

Hi! The overall theme is provided by tabler, which does support dark mode, so it shouldn't be too hard to do.

The first thing you can do is customize your own shell component locally. Create a shell.handlebars file in sqlpage/templates.

Copy the official shell, and switch to tabler's dark mode by adding the theme-dark CSS class on the body.

If it works well, you can open a pull request here to add an option in the shell template for dark mode.

@lovasoa lovasoa added the enhancement New feature or request label Aug 7, 2023
@lovasoa
Copy link
Collaborator

lovasoa commented Aug 7, 2023

My mistake, it looks like it's not class="theme-dark", but data-bs-theme="dark"

image

@accforgithubtest , do you want to make the small PR ?

It could be as simple as adding

{{#if dark}}
   data-bs-theme="dark"
{{/if}}

to shell.handlebars

@lovasoa
Copy link
Collaborator

lovasoa commented Aug 19, 2023

done 🎊 ✔️

This will be in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants