Fix arguments handling in KSType.toTypeName() #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
approved these changes
Apr 24, 2023
| null | ||
| } | ||
| val superInterfaces = if (superclassReference != null) { | ||
| allSupertypes.drop(1) |
There was a problem hiding this comment.
Are we guaranteed to have the superclass at a specific position in the superTypes list? Would it be safer to do filterNot { it == superclassReference }?
There was a problem hiding this comment.
Good catch bf481db
slack-oss-bot
referenced
this pull request
in slackhq/circuit
Apr 29, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.squareup:kotlinpoet-ksp](https://github.com/square/kotlinpoet) | dependencies | patch | `1.13.0` -> `1.13.1` | | [com.squareup:kotlinpoet](https://github.com/square/kotlinpoet) | dependencies | patch | `1.13.0` -> `1.13.1` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>square/kotlinpoet</summary> ### [`v1.13.1`](https://github.com/square/kotlinpoet/releases/tag/1.13.1) [Compare Source](https://github.com/square/kotlinpoet/compare/1.13.0...1.13.1) ##### What's Changed - Fix: Look at canonical names instead of just package names when generating import aliases by [@​Egorand](https://github.com/Egorand) in [https://github.com/square/kotlinpoet/pull/1519](https://github.com/square/kotlinpoet/pull/1519) - Fix: Ignore KSP annotation arguments without a value by [@​rickclephas](https://github.com/rickclephas) in [https://github.com/square/kotlinpoet/pull/1523](https://github.com/square/kotlinpoet/pull/1523) - Fix: Fix arguments handling in KSType.toTypeName() by [@​ZacSweers](https://github.com/ZacSweers) in [https://github.com/square/kotlinpoet/pull/1529](https://github.com/square/kotlinpoet/pull/1529) ##### New Contributors - [@​rickclephas](https://github.com/rickclephas) made their first contribution in [https://github.com/square/kotlinpoet/pull/1523](https://github.com/square/kotlinpoet/pull/1523) **Full Changelog**: square/kotlinpoet@1.13.0...1.13.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42NC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more or less undoes #1321 as it broke arguments handling in an unrelated way to annotations. I'm not able to actually repro the original issue it sought to solve in #1304, and added a regression test. This resolves #1513, though the examples there were not helpful either. All in all, I have a headache.