Set read/write permissions after creating the .hprof file #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sylwek845
changed the title
|
@sylwek845 I'm catching up on PRs. Did you close this because the fix wasn't necessary after all, or just because of the lack of response? |
|
@pyricau mostly because I wanted to run release (my own version with fixes) and test for longer period of time. it seems to work but I had to apply the change in one more place so I will update the branch and will raise the PR again today. Thanks for response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No easy steps to reproduce. We use additional tool to shield our apk, and it seems to only happen after the app is shielded. It fails on reading the file back, when inspecting the .hprof file in cache, I noticed that it has no permissions
--------instead of--rw----which causes the analysis to fail. We see this behaviour for all libs (startup/release/integration).More info in #2579