Add known UiModeManager memory leak from Android OS #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyricau
reviewed
Feb 16, 2024
| Fixed in Android 14.0.0_r16: https://cs.android.com/android/_/android/platform/frameworks/base/+/2bc364179327022d0f60224a1f2420349074c5d2 | ||
| """.trimIndent() | ||
| ) { | ||
| sdkInt == 34 |
There was a problem hiding this comment.
Thanks for this, however for these stub leaks we typically reference them as a global native ref to the instance directly, because the core issue is with stubs sticking around in memory long after they're needed, and that way any reference from the stub to elsewhere is also included in this.
There was a problem hiding this comment.
Thanks for the explanation)
If I understood correctly, then we should refer in this case to android.app.UiModeManager$1 using the nativeGlobalVariableLeak method
|
Thx! |
EpicDima
deleted the
epicdima/add_to_ignored_UiModeManager_context_leak
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2559