Generated serialization for field named with hot keywords

[dbarwacz]

I use class as response field. In kotlin:

@Keep
@JsonClass(generateAdapter = true)
data class StaticLabelField(
        override val key: String,
        override val label: String,
        override val order: Int,
        override val condition: Condition? = null,
        val `class`: List<String>?
) : Field(), Validatable {
    override fun validator() = null
}

When using moshi to generate adapter code, it's not 'blocking/escaping' that field in toJson method:

override fun toJson(writer: JsonWriter, value: Field.StaticLabelField?) {
    if (value == null) {
        throw NullPointerException("value was null! Wrap in .nullSafe() to write nullable values.")
    }
    writer.beginObject()
    writer.name("key")
    stringAdapter.toJson(writer, value.key)
    writer.name("label")
    stringAdapter.toJson(writer, value.label)
    writer.name("order")
    intAdapter.toJson(writer, value.order)
    writer.name("condition")
    nullableConditionAdapter.toJson(writer, value.condition)
    writer.name("class")
    nullableListOfStringAdapter.toJson(writer, value.class) // <==== field with name 'class' has different result than intended.
    writer.endObject()
}

I worked it around by using Json annotation and different name for the field, but I think this is a bug that might be worth fixing.

[NightlyNexus]

good find. thanks for the report.

[ZacSweers]

We'd need to either copy KotlinPoet's escapeKeywords or ask for it to be a public API. @Egorand thoughts?

[Egorand]

Latest snapshot has some improvements on that point, make sure you use %N when emitting names that might require escaping and KP will escape them for you. If that works I can cut a release.

[ZacSweers]

Will try it out!

[ZacSweers]

Confirmed this works on the latest version of kotlinpoet. We'll update to that before the release

[cortinico]

Confirmed this works on the latest version of kotlinpoet. We'll update to that before the release

Do we have an ETA for the next stable release? I'm just asking as this is blocking us on Yelp/swagger-gradle-codegen#62

[ZacSweers]

When it's ready!

…

On Wed, Sep 18, 2019 at 12:00 PM Nicola Corti ***@***.***> wrote: Confirmed this works on the latest version of kotlinpoet. We'll update to that before the release Do we have an ETA for the next stable release? I'm just asking as this is blocking us on Yelp/swagger-gradle-codegen#62 <Yelp/swagger-gradle-codegen#62> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#848?email_source=notifications&email_token=AAKMJPQ63NIT7FF63S56IRDQKJGDDA5CNFSM4HL5M27KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ASLYQ#issuecomment-532751842>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKMJPSEMIFL457NMZ3ABY3QKJGDDANCNFSM4HL5M27A> .