Merge pull request #23 from square/jwilson/deleted

Merge: Tolerate cache files being removed from underneath DiskLruCache
square · Sep 19, 2012 · 19d8cf1 · 19d8cf1
2 parents 1d57bed + 1bc9e2e
commit 19d8cf1
Show file tree

Hide file tree

Showing 3 changed files with 842 additions and 2 deletions.
diff --git a/src/main/java/libcore/io/DiskLruCache.java b/src/main/java/libcore/io/DiskLruCache.java
@@ -453,9 +453,16 @@ private synchronized void completeEdit(Editor editor, boolean success) throws IO
         // if this edit is creating the entry for the first time, every index must have a value
         if (success && !entry.readable) {
             for (int i = 0; i < valueCount; i++) {
+                if (!editor.written[i]) {
+                    editor.abort();
+                    throw new IllegalStateException(
+                            "Newly created entry didn't create value for index " + i);
+                }
                 if (!entry.getDirtyFile(i).exists()) {
                     editor.abort();
-                    throw new IllegalStateException("edit didn't create file " + i);
+                    Libcore.logW(
+                            "DiskLruCache: Newly created entry doesn't have file for index " + i);
+                    return;
                 }
             }
         }
@@ -654,10 +661,12 @@ public String getString(int index) throws IOException {
      */
     public final class Editor {
         private final Entry entry;
+        private final boolean[] written;
         private boolean hasErrors;
 
         private Editor(Entry entry) {
             this.entry = entry;
+            this.written = (entry.readable) ? null : new boolean[valueCount];
         }
 
         /**
@@ -697,6 +706,9 @@ public OutputStream newOutputStream(int index) throws IOException {
                 if (entry.currentEditor != this) {
                     throw new IllegalStateException();
                 }
+                if (!entry.readable) {
+                    written[index] = true;
+                }
                 return new FaultHidingOutputStream(new FileOutputStream(entry.getDirtyFile(index)));
             }
         }

diff --git a/src/main/java/libcore/net/http/HttpResponseCache.java b/src/main/java/libcore/net/http/HttpResponseCache.java
@@ -425,7 +425,7 @@ public Entry(URI uri, RawHeaders varyHeaders, OkHttpConnection httpConnection) {
         }
 
         public void writeTo(DiskLruCache.Editor editor) throws IOException {
-            OutputStream out = editor.newOutputStream(0);
+            OutputStream out = editor.newOutputStream(ENTRY_METADATA);
             Writer writer = new BufferedWriter(new OutputStreamWriter(out, Charsets.UTF_8));
 
             writer.write(uri + '\n');