`isCleartextTrafficPermitted()` fails on OpenJDK 8 + Robolectric #2533

kungfoo · 2016-05-04T08:33:11Z

How to reproduce:

Install OpenJDK 8
Use current 3.3.0-SNAPSHOT version
new OkHttpClient(): The code fails in the static initializer, when trying to figure out the platform.

The code that breaks was introduced here: #2513

Either the detection of the runtime is broken, or the code is wrong there. I'll try to figure out an automatic test for this.

The text was updated successfully, but these errors were encountered:

kungfoo · 2016-05-04T08:33:54Z

This is when running tests with Roboelectric, BTW. So maybe the code determines, the Platform is android, when it's actually not.

kungfoo · 2016-05-04T09:01:44Z

I tried to write up a simple testcase that reproduces this, but apparently it truly is the combination of the following things that make the code fail:

OpenJDK 8
Current Snapshot
Roboelectric (needs to be an android project for this)

kungfoo · 2016-05-04T09:33:55Z

Okay, so because the setup is kinda contrived: Here is a sample that reproduces this...

https://github.com/kungfoo/okhttp-on-jdk-with-robolectric

swankjesse · 2016-05-04T12:53:38Z

Does it throw or return the wrong result?

kungfoo · 2016-05-04T13:05:43Z

It crashes/throws in the static initializer which results in a
ClassNotFoundException.
On May 4, 2016 14:54, "Jesse Wilson" notifications@github.com wrote:

Does it throw or return the wrong result?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2533 (comment)

swankjesse · 2016-05-04T14:55:39Z

@kungfoo could you paste the stacktrace?

kungfoo · 2016-05-04T16:22:10Z

Will do later when I get my laptop back online...
On May 4, 2016 16:56, "Jesse Wilson" notifications@github.com wrote:

@kungfoo https://github.com/kungfoo could you paste the stacktrace?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2533 (comment)

kungfoo · 2016-05-04T20:04:15Z

If you want to debug the code under the described circumstances, you can simply use gradle to run the sample project I created for this.

Here's the stacktrace:

at okhttp3.internal.Platform$Android.isCleartextTrafficPermitted(Platform.java:324)
    at okhttp3.OkHttpClient.<clinit>(OkHttpClient.java:73)
    at ch.ergon.sample.CreateOkHttpClientTest.canCreateAClient(CreateOkHttpClientTest.java:17)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:483)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:251)
    at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:188)
    at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:54)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:152)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:112)
    at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
    at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
    at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:483)

swankjesse · 2016-05-05T04:08:18Z

Wanna submit a fix?

kungfoo · 2016-05-05T09:09:01Z

Might be able to do that, when I'm back out of the woods... :)
On May 5, 2016 06:09, "Jesse Wilson" notifications@github.com wrote:

Wanna submit a fix?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2533 (comment)

eygraber · 2016-05-26T04:56:32Z

Here's the message for the target Exception of the InvocationTargetException that gets thrown when calling the offending Method.invoke

Method getInstance in android.security.NetworkSecurityPolicy not mocked. See http://g.co/androidstudio/not-mocked for details.

JakeWharton · 2016-05-26T05:06:24Z

Sounds like you're not using Robolectric since that message comes from the
mockable jar.

On Thu, May 26, 2016 at 12:56 AM Eliezer Graber notifications@github.com
wrote:

Here's the message for the target Exception of the
InvocationTargetException that gets thrown when calling the offending
Method.invoke
e3cd9b9#diff-5803d99d45dfa6a23e51dd60d44f2de9R314

Method getInstance in android.security.NetworkSecurityPolicy not mocked.
See http://g.co/androidstudio/not-mocked for details.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#2533 (comment)

eygraber · 2016-05-26T05:09:51Z

I'm definitely using Robolectric (verified on the call stack), which is why I was confused. Could it be a classloader issue where Class.forname is using the platform class?

JakeWharton · 2016-05-26T05:11:54Z

Maybe, but that would be a robolectric bug in its ParallelUniverse then. If
Class.forName didn't work then things like LayoutInflater wouldn't work
either.

On Thu, May 26, 2016 at 1:09 AM Eliezer Graber notifications@github.com
wrote:

I'm definitely using Robolectric (verified on the call stack), which is
why I was confused. Could it be a classloader issue where Class.forname
is using the platform class?

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#2533 (comment)

eygraber · 2016-05-26T05:21:17Z

Could it be happening because I'm on Robolectric 2.4 (which I believe only supports up to API 18), and NetworkSecurityPolicy wasn't added until API 23?

JakeWharton · 2016-05-26T05:22:32Z

Possibly. Try the latest.

On Thu, May 26, 2016 at 1:21 AM Eliezer Graber notifications@github.com
wrote:

Could it be happening because I'm on Robolectric 2.4 (which I believe only
supports up to API 18), and NetworkSecurityPolicy wasn't added until API
23?

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#2533 (comment)

eygraber · 2016-05-26T05:34:05Z

We're pretty stuck on 2.4, so I used the project referenced above and changed the robolectric properties to use API 23. I was greeted by this when running the test:

java.lang.UnsupportedOperationException: Robolectric does not support API level 23.

JakeWharton · 2016-05-26T05:37:37Z

Seems like a clear deficiency on their side then. Not sure what action
there would be for us to take.

On Thu, May 26, 2016 at 1:34 AM Eliezer Graber notifications@github.com
wrote:

We're pretty stuck on 2.4, so I used the project referenced above
#2533 (comment) and
change the robolectric properties to use API 23. I was greeted by this when
running the test:

java.lang.UnsupportedOperationException: Robolectric does not support API
level 23.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#2533 (comment)

eygraber · 2016-05-26T06:11:24Z

Would wrapping it in a version check help?

JakeWharton · 2016-05-26T06:12:48Z

It's already behind one. You're compiling with API 23 (or newer) and thus
OkHttp attempts to use APIs from that version.

On Thu, May 26, 2016 at 2:11 AM Eliezer Graber notifications@github.com
wrote:

Would wrapping it in a version check help?

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#2533 (comment)

eygraber · 2016-05-26T06:37:16Z

Would that affect a runtime check? Something like:

Class c = Class.forName("android.os.Build$VERSION");
Field f = c.getDeclaredField("SDK_INT");
int apiLevel = f.getInt(null);

When I try that running in Robolectric it returns 21.

meoyawn · 2016-05-29T12:46:32Z

I'm getting

java.lang.AssertionError
    at okhttp3.internal.AndroidPlatform.isCleartextTrafficPermitted(AndroidPlatform.java:143)
    at okhttp3.OkHttpClient.<clinit>(OkHttpClient.java:73)
    at okhttp3.OkHttpClient$Builder.<init>(OkHttpClient.java:381)

with okhttp 3.3.1 and both robolectric 3.0 and 3.1-rc1
all good with okhttp 3.2.+

dave-r12 · 2016-05-29T15:30:40Z

I was able to get the test green. Here's what I did:

Change to using OkHttp-3.3.1. The project was using a SNAPSHOT version, but 3.3 has since been released.
Upgrade to robolectric 3.1-rc1.
Added config annotation with SDK specified to the test class:

@RunWith(RobolectricGradleTestRunner.class)
@Config(sdk = 23)
public class CreateOkHttpClientTest {

As for why it works, I don't know. It appears the default SDK is 21. The bit I don't understand is why it isn't throwing a ClassNotFoundException given this class is only in SDK 23. The test project itself is depending on API 23, which may have something to do with it.

dave-r12 · 2016-05-29T17:10:39Z

I have a vague idea of why this works now, and I opened up an issue on robolectric project. Let's see what they say, robolectric/robolectric#2478

felipecsl · 2016-05-31T18:58:27Z

Robolectric 3.1-rc1 is pretty much unusable right now, as running tests take ~10x longer. Any other workarounds?

felipecsl · 2016-07-18T22:02:52Z

Oh, It works if you add a String argument to the isCleartetTrafficPermitted shadow method. Here's the updated (hideous) workaround:

@Implements(NetworkSecurityPolicy.class)
public class NetworkSecurityPolicyWorkaround {
    @Implementation
    public static NetworkSecurityPolicy getInstance() {
        //noinspection OverlyBroadCatchBlock
        try {
            Class<?> shadow = Class.forName("android.security.NetworkSecurityPolicy");
            return (NetworkSecurityPolicy) shadow.newInstance();
        } catch (Exception e) {
            throw new AssertionError();
        }
    }

    @Implementation
    public boolean isCleartextTrafficPermitted(String hostname) {
        return true;
    }
}

Summary: - 3.3.1 wasn't compatible with Robolectric 3.0, however 3.4.0 [fixes](square/okhttp#2533 (comment)) this issue. - Few other fixes to OkHttp mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) > Fixes: #7743 > - Android apps can recover from a `REFUSED_STREAM` in HTTP/2. - A few other fixes mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - CircleCi - Test with `/Examples` ✅ Closes #8672 Reviewed By: alsutton Differential Revision: D3541293 Pulled By: bestander fbshipit-source-id: 76429861b4f4df15cb9c18ab0f177daee3e1459d

Summary: - 3.3.1 wasn't compatible with Robolectric 3.0, however 3.4.0 [fixes](square/okhttp#2533 (comment)) this issue. - Few other fixes to OkHttp mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) > Fixes: facebook#7743 > - Android apps can recover from a `REFUSED_STREAM` in HTTP/2. - A few other fixes mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - CircleCi - Test with `/Examples` ✅ Closes facebook#8672 Reviewed By: alsutton Differential Revision: D3541293 Pulled By: bestander fbshipit-source-id: 76429861b4f4df15cb9c18ab0f177daee3e1459d

thalescm · 2016-09-06T11:42:13Z

I'm not using Roboeletric, but i'm in pointing towards API 24, with okhttp version 3.4.1:
My problem is that I'm getting a NullPointerException (when running UnitTests) in okhttp3.internal.platform.AndroidPlatform when trying to run method:

@Override public boolean isCleartextTrafficPermitted(String hostname) {
    try {
      Class<?> networkPolicyClass = Class.forName("android.security.NetworkSecurityPolicy");
      Method getInstanceMethod = networkPolicyClass.getMethod("getInstance");
      Object networkSecurityPolicy = getInstanceMethod.invoke(null);
      Method isCleartextTrafficPermittedMethod = networkPolicyClass
          .getMethod("isCleartextTrafficPermitted", String.class);
      return (boolean) isCleartextTrafficPermittedMethod.invoke(networkSecurityPolicy, hostname);
    } catch (ClassNotFoundException | NoSuchMethodException e) {
      return super.isCleartextTrafficPermitted(hostname);
    } catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
      throw new AssertionError();
    }
  }

which comes from RealConnection::connect.
Debugging it, it happens on the actual invoke isCleartextTrafficPermittedMethod.invoke(networkSecurityPolicy, hostname).
This problem didn't happen to me at version 3.2.0...
Can anyone help me?

thalescm · 2016-09-06T11:51:44Z

@felipecsl solution (for those who can't upgrade to Robolectric 3+) works in this case too. But I really wouldn't like to use that :(

PaulWoitaschek · 2016-12-13T10:40:00Z

Happens with OkHttp 3.5.0 and robolectric 3.1.4

vRallev · 2017-01-16T13:36:43Z

We're running into the same issue with OkHttp 3.5.0. Instead of using Robolectric directly we use unmock (which relies on Robolectric's android-all jar).

teburd · 2017-02-01T20:15:02Z

I'm so glad I found this ticket, was going crazy trying to understand why okhttp suddenly had an exception when running with robolectric

xstherrera1987 · 2017-03-09T02:42:41Z

I am also still seeing this, but have resolved it with same fix as @eygraber.
note that I'm not on OpenJDK as OP was

OkHttp 3.6.0
Robolectric 3.3 only for @Config(sdk = _) < 23
Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode) on OSX

add to unit-tests source-set only, eg: project-dir/app/src/test/java/android/security by default

package android.security;
// https://github.com/square/okhttp/issues/2533#issuecomment-223093100
public class NetworkSecurityPolicy {
    private static final NetworkSecurityPolicy INSTANCE = new NetworkSecurityPolicy();
    @SuppressLint("NewApi") public static NetworkSecurityPolicy getInstance() { return INSTANCE; }
    public boolean isCleartextTrafficPermitted() { return true; }
}

lastly note that this may break with OkHttp 3.7.x

swankjesse · 2017-08-30T18:41:46Z

Is there anything to do in OkHttp for this?

yschimke · 2017-12-30T07:49:53Z

Reading this, seems like it is fixed in Robolectric 3.3

Summary: - 3.3.1 wasn't compatible with Robolectric 3.0, however 3.4.0 [fixes](square/okhttp#2533 (comment)) this issue. - Few other fixes to OkHttp mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) > Fixes: #7743 > - Android apps can recover from a `REFUSED_STREAM` in HTTP/2. - A few other fixes mentioned in the [CHANGELOG.md](https://github.com/square/okhttp/blob/master/CHANGELOG.md) - CircleCi - Test with `/Examples` ✅ Closes facebook/react-native#8672 Reviewed By: alsutton Differential Revision: D3541293 Pulled By: bestander fbshipit-source-id: 76429861b4f4df15cb9c18ab0f177daee3e1459d

swankjesse changed the title ~~isCleartextTrafficPermitted() fails on OpenJDK 8 (1.8.0_92-b14)~~ isCleartextTrafficPermitted() fails on OpenJDK 8 + Robolectric May 5, 2016

swankjesse added the needs info More information needed from reporter label May 8, 2016

swankjesse added this to the 3.4 milestone May 8, 2016

swankjesse added the bug Bug in existing code label May 8, 2016

JakeWharton mentioned this issue May 30, 2016

AssertionError when running Unit Tests on Android with Robolectric #2591

Closed

jwir3 mentioned this issue Aug 17, 2016

IncompatibleClassChangeError andrzejchm/RESTMock#38

Closed

swankjesse modified the milestones: 3.6, 3.5 Nov 20, 2016

aafa added a commit to aafa/bitrader that referenced this issue Dec 11, 2016

robo fixed square/okhttp#2533

aa1b4ff

swankjesse modified the milestones: 3.6, 3.7 Jan 29, 2017

swankjesse modified the milestones: 3.7, 3.8 Apr 28, 2017

swankjesse modified the milestones: 3.10, 3.9 Aug 30, 2017

yschimke closed this as completed Dec 30, 2017

yschimke mentioned this issue Mar 16, 2018

NullPointerException on Android when hostname is null on all versions after 3.2.0 #3928

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`isCleartextTrafficPermitted()` fails on OpenJDK 8 + Robolectric #2533

`isCleartextTrafficPermitted()` fails on OpenJDK 8 + Robolectric #2533

kungfoo commented May 4, 2016

kungfoo commented May 4, 2016 •

edited

Loading

kungfoo commented May 4, 2016

kungfoo commented May 4, 2016

swankjesse commented May 4, 2016

kungfoo commented May 4, 2016

swankjesse commented May 4, 2016

kungfoo commented May 4, 2016

kungfoo commented May 4, 2016

swankjesse commented May 5, 2016

kungfoo commented May 5, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016 •

edited

Loading

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

meoyawn commented May 29, 2016

dave-r12 commented May 29, 2016

dave-r12 commented May 29, 2016

felipecsl commented May 31, 2016

felipecsl commented Jul 18, 2016

thalescm commented Sep 6, 2016 •

edited

Loading

thalescm commented Sep 6, 2016 •

edited

Loading

PaulWoitaschek commented Dec 13, 2016

vRallev commented Jan 16, 2017 •

edited

Loading

teburd commented Feb 1, 2017

xstherrera1987 commented Mar 9, 2017

swankjesse commented Aug 30, 2017

yschimke commented Dec 30, 2017

isCleartextTrafficPermitted() fails on OpenJDK 8 + Robolectric #2533

isCleartextTrafficPermitted() fails on OpenJDK 8 + Robolectric #2533

Comments

kungfoo commented May 4, 2016

kungfoo commented May 4, 2016 • edited Loading

kungfoo commented May 4, 2016

kungfoo commented May 4, 2016

swankjesse commented May 4, 2016

kungfoo commented May 4, 2016

swankjesse commented May 4, 2016

kungfoo commented May 4, 2016

kungfoo commented May 4, 2016

swankjesse commented May 5, 2016

kungfoo commented May 5, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016 • edited Loading

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

JakeWharton commented May 26, 2016

eygraber commented May 26, 2016

meoyawn commented May 29, 2016

dave-r12 commented May 29, 2016

dave-r12 commented May 29, 2016

felipecsl commented May 31, 2016

felipecsl commented Jul 18, 2016

thalescm commented Sep 6, 2016 • edited Loading

thalescm commented Sep 6, 2016 • edited Loading

PaulWoitaschek commented Dec 13, 2016

vRallev commented Jan 16, 2017 • edited Loading

teburd commented Feb 1, 2017

xstherrera1987 commented Mar 9, 2017

swankjesse commented Aug 30, 2017

yschimke commented Dec 30, 2017

`isCleartextTrafficPermitted()` fails on OpenJDK 8 + Robolectric #2533

`isCleartextTrafficPermitted()` fails on OpenJDK 8 + Robolectric #2533

kungfoo commented May 4, 2016 •

edited

Loading

eygraber commented May 26, 2016 •

edited

Loading

thalescm commented Sep 6, 2016 •

edited

Loading

thalescm commented Sep 6, 2016 •

edited

Loading

vRallev commented Jan 16, 2017 •

edited

Loading