Apply fix for devices with large socket buffers #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same fix as for ThreadInterruptTest from commit d95341b, but made to DisconnectTest.
|
I just noticed that we are trying to fix the same failing test. I sent in #1198 a few minutes ago. I decided to remove the failing test case entirely because it's not testing anything except the java.net.HttpURLConnection that I can see -- nothing specific to okhttp. |
|
@mruddy It tests OkHttp's implementation of |
|
@JakeWharton ah, ok, I didn't see that. |
nfuller
added a commit
to nfuller/okhttp
that referenced
this pull request
Dec 15, 2014
Work in progress. I see a new failure from a certificate pinning test but I don't know why. Help solving this would be appreciated. I also see failures before & after: 1) A failure from DisconnectTest (square#1197 may fix that). 2) A failure from CallTest.doesNotFollow21Redirects_Async (timeout) The maven changes should be treated with the contempt they deserve. I mostly removed things I didn't understand and stroked maven until it stopped squealing. The benchmarks / okcurl changes are a particular mystery. Tried with arbitrary versions of openjdk7 and openjdk8 I had lying around. Behavior seems the same.
nfuller
added a commit
to nfuller/okhttp
that referenced
this pull request
Dec 15, 2014
Work in progress. I see a new failure from a certificate pinning test but I don't know why. Help solving this would be appreciated. I also see failures before & after: 1) A failure from DisconnectTest (square#1197 may fix that). 2) A failure from CallTest.doesNotFollow21Redirects_Async (timeout) The maven changes should be treated with the contempt they deserve. I mostly removed things I didn't understand and stroked maven until it stopped squealing. The benchmarks / okcurl changes are a particular mystery. Tried with arbitrary versions of openjdk7 and openjdk8 I had lying around. Behavior was the same across both (i.e. the same failures).
|
Thanks! |
swankjesse
added a commit
that referenced
this pull request
Dec 16, 2014
Apply fix for devices with large socket buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same fix as for ThreadInterruptTest from commit
d95341b, but made to
DisconnectTest.