Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the GMS security provider when searching for the trust manager. #2325

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

swankjesse
Copy link
Collaborator

Closes #2323

@vangliana
Copy link

It would be good if a release is made once this gets merged. This issue is wrecking havoc with any test relying on Robolectric runner

JakeWharton added a commit that referenced this pull request Feb 8, 2016
Support the GMS security provider when searching for the trust manager.
@JakeWharton JakeWharton merged commit 1952a10 into master Feb 8, 2016
@JakeWharton JakeWharton deleted the jwilson_0207_filthy branch February 8, 2016 00:53
@JakeWharton
Copy link
Collaborator

@vangliana You can use the previous release, the SNAPSHOT from Sonatype's snapshot repository, or JitPack until a release is made.

@vangliana
Copy link

@JakeWharton previous release is no good since okhttp3.OkHttpClient modifier is final which breaks my mocks. I'll use the snapshot instead.

@JakeWharton
Copy link
Collaborator

Mocking OkHttpClient is an anti-pattern. You can mock or fake Call.Factory instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants