Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Code Scanning #6304

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Enable GitHub Code Scanning #6304

merged 1 commit into from
Oct 2, 2020

Conversation

ddz
Copy link
Contributor

@ddz ddz commented Oct 2, 2020

Created a codeql-analysis.yml to configure GitHub workflow for code scanning.

  • Added Setup Java action to override default Java 8.
  • Added custom build command from CircleCI yml commented out in case CodeQL autobuild fails in the future.

Add codeql-analysis.yml to configure GitHub workflow for code security scanning. Added Setup Java action to override default Java 8.
@swankjesse swankjesse merged commit eba8a83 into square:master Oct 2, 2020
@swankjesse
Copy link
Collaborator

Perhaps this doesn't help with .kt files?
https://help.semmle.com/codeql/supported-languages-and-frameworks.html

@ddz
Copy link
Contributor Author

ddz commented Oct 3, 2020

Yes, doesn't look like Kotlin is supported yet, but it appears to be on their radar. So this scanning will only cover samples, mockwebserver, and some test code until then. It's definitely debatable whether it's worth the additional CI time until then.

@yschimke
Copy link
Collaborator

yschimke commented Oct 3, 2020

It's definitely debatable whether it's worth the additional CI time until then.

Seems like a good initiative to support and will be nice when it becomes active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants