Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Backport 1XX handling from master #7634

Merged
merged 8 commits into from
Jan 12, 2023

Conversation

yschimke
Copy link
Collaborator

@yschimke yschimke commented Jan 5, 2023

In progress, test is difficult without informational responses.

@yschimke yschimke changed the base branch from master to okhttp_4.10.x January 5, 2023 12:18
@yschimke yschimke marked this pull request as ready for review January 6, 2023 07:58
@yschimke
Copy link
Collaborator Author

yschimke commented Jan 6, 2023

@swankjesse I think a mostly manual test is the best I can do.

import org.junit.Rule
import org.junit.Test

@Ignore("For manual testing only")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled as we don't want to test an external site.

And we don't want to backport changes to the mockwebserver in 5.x

@yschimke yschimke changed the title [4.10.x] Backport 1XX handling from master [4.x] Backport 1XX handling from master Jan 12, 2023
@swankjesse swankjesse merged commit 949262e into square:okhttp_4.10.x Jan 12, 2023
@yschimke yschimke deleted the patch branch May 27, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants