Add hpack-test-case based tests #976
Conversation
| import com.squareup.okhttp.internal.spdy.hpackjson.Story; | ||
| import okio.Buffer; | ||
|
|
||
| import java.util.*; |
|
LGTM. Please address issues above, and squash your commits! |
| TODO | ||
| ---- | ||
|
|
||
| * Make hpack-test-case update itself from git, and notify if there are new |
There was a problem hiding this comment.
ultranit: one space before, one space after bullet?
* Make hpack-test-case....
There was a problem hiding this comment.
Nope you've gotta add new interop tests by hand
On Jul 1, 2014 8:42 AM, "Jesse Wilson" notifications@github.com wrote:
In okhttp-hpacktests/README.md:
@@ -0,0 +1,16 @@
+OkHttp HPACK tests
+==================
+
+These tests use the [hpack-test-case][1] project to validate OkHttp's HPACK
+implementation.
+
+TODO
+----
+
+* Make hpack-test-case update itself from git, and notify if there are newdone?
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/pull/976/files#r14411738.
|
Do you need to |
|
OK all set ramping up on tools. |
|
Some comments might not have been addressed, ex. the copyright. Please scan back through and make sure the commit that is visible includes them. Also, I would take a little time to make the README clear at least on the process to initialize the project and what to do when the hpack tests upstream project changes. Since we are linking to something else, we want to ensure the maintenance aspect of this isn't subject to bus factor. otherwise LGTM and I will look at the failing tests for relevance, etc once merged. |
|
k should be all set |
|
Just got back from vacation and finally circling back to this. This looks awesome. I'm eager to put it to use. |
Add hpack-test-case based tests
For isssue #931 this creates a submodule referencing http2jp/hpack-test-case, and runs the decoder across each of the directories for interop testing. Many of these fail, so they're in an @ignored bad test.
Another test added does a round trip of headers through our encoder and decoder -- this test is not quite as effective as having known good output of our own in http2jp/hpack-test-case so that's next.