Improve support for Unit as the return type #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansman
commented
Feb 25, 2022
| @@ -83,6 +84,12 @@ suspend fun <T : Any> Call<T?>.await(): T? { | |||
| } | |||
| } | |||
|
|
|||
| @JvmName("awaitUnit") | |||
| suspend fun Call<Unit>.await() { | |||
There was a problem hiding this comment.
If you prefer this could be made internal but the type resolution seems to work fine so it seems like a nice addition.
ansman
force-pushed
the
improve-unit-support
branch
from
919756b
to
2aeaae4
Compare
|
I just noticed that #3648 fixes the head stuff so I could revert that part. |
ansman
force-pushed
the
improve-unit-support
branch
from
2aeaae4
to
55fc7a2
Compare
|
This looks good. I'll review in depth next week. Retrofit is high up on my backlog of things to work on. |
JakeWharton
force-pushed
the
improve-unit-support
branch
3 times, most recently
from
4fa1586
to
d3d30ac
Compare
Specifically this change fixes two cases: - Using Unit for with suspending functions for responses without a body. - Using Unit for HEAD requests.
JakeWharton
force-pushed
the
improve-unit-support
branch
from
d3d30ac
to
9eedffd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this change fixes two cases:
This fixes #2888 but in a more compatible way. Closes #3648. Closes #3470.