Upgrade gradle to 7.0. #420
Conversation
|
Seems like we finally need to get off our super-old Dokka version to unblock this. |
|
Dokka upgrade in #421 should unblock this. |
|
Looks like we need to upgrade the ktlint plugin as well, latest version is 10.0.0. |
|
And detekt, 1.16.0. Which now fails a bunch of stuff that was perfectly fine before… |
zach-klippenstein
force-pushed
the
zachklipp/upgrade-gradle
branch
from
7bb0fb2 to
1253b62
Compare
|
Wasn't able to figure out how to get detekt to actually generate a baseline, so shelving this for now. |
|
I'm not sure we've ever really gotten value from detekt anyway. Ktlint is probably all we really need. @rjrjr how serious were you? |
|
Completely. I don't care even a little about detekt.
…On Tue, May 11, 2021 at 8:47 AM Zach Klippenstein ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/101754/117845321-496fb300-b235-11eb-9e17-2ef4fefbfbbb.jpeg>
👀
I'm not sure we've ever really gotten value from detekt anyway. Ktlint is
probably all we really need. @rjrjr <https://github.com/rjrjr> how
serious were you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOMCHJFHX7LFCUYBYM4VXDTNFGRJANCNFSM44ROI55Q>
.
|
This change was discussed and agreed upon in #420, since we don't get any value out of detekt and it makes maintaining our build scripts more difficult.
|
Removed detekt in #426, rebasing this on top of that… |
This change was discussed and agreed upon in #420, since we don't get any value out of detekt and it makes maintaining our build scripts more difficult.
zach-klippenstein
force-pushed
the
zachklipp/upgrade-gradle
branch
from
1253b62 to
8daa358
Compare
zach-klippenstein
force-pushed
the
zachklipp/upgrade-gradle
branch
from
8daa358 to
3f38b9b
Compare
|
Updated jmh (benchmarking) and ktlint gradle plugins to their latest versions, required for Gradle 7. |
|
Added a separate commit that updates gradle and AGP for the compose project. I did both there because AGP was so far behind. |
|
|
||
| // We had to disable the indent and parameter-list-wrapping rules, because they lead to | ||
| // false positives even in the most recent KtLint version. We created tickets: | ||
| // | ||
| // https://github.com/pinterest/ktlint/issues/963 | ||
| // https://github.com/pinterest/ktlint/issues/964 | ||
| // https://github.com/pinterest/ktlint/issues/965 | ||
| // | ||
| // We can't revert the KtLint version, because they only work with Kotlin 1.3 and would | ||
| // block Kotlin 1.4. We rather have a newer Kotlin version than a proper indent. The | ||
| // indent rule needs to be disabled globally due to another bug: | ||
| // https://github.com/pinterest/ktlint/issues/967 | ||
| "indent", | ||
| "parameter-list-wrapping" |
There was a problem hiding this comment.
I just copied this in from the main project's build.gradle.
| // This is a known issue: https://github.com/pinterest/ktlint/issues/527 | ||
| "import-ordering", |
There was a problem hiding this comment.
A heads-up just in case you're interested in a follow-on PR:
It looks like the import-ordering issue has been (mostly) fixed thanks to the introduction of a layout table for Kotlin imports. (But note the misbehavior cited at the end of that conversation, including a comment by the tried-and-true Valeriy Ovechkin 😺 .)
There was a problem hiding this comment.
I'm not interesting in diverging these effectively duplicate configs any more than necessary. We can follow up and address in the main project once these have merged.
|
|
||
| // We had to disable the indent and parameter-list-wrapping rules, because they lead to | ||
| // false positives even in the most recent KtLint version. We created tickets: | ||
| // | ||
| // https://github.com/pinterest/ktlint/issues/963 | ||
| // https://github.com/pinterest/ktlint/issues/964 | ||
| // https://github.com/pinterest/ktlint/issues/965 | ||
| // | ||
| // We can't revert the KtLint version, because they only work with Kotlin 1.3 and would | ||
| // block Kotlin 1.4. We rather have a newer Kotlin version than a proper indent. The | ||
| // indent rule needs to be disabled globally due to another bug: | ||
| // https://github.com/pinterest/ktlint/issues/967 | ||
| "indent", | ||
| "parameter-list-wrapping" |
No description provided.