Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linters to CI for Swift #33

Closed
asthatrivedi opened this issue Apr 23, 2020 · 0 comments · Fixed by #316
Closed

Add Linters to CI for Swift #33

asthatrivedi opened this issue Apr 23, 2020 · 0 comments · Fixed by #316

Comments

@asthatrivedi
Copy link
Collaborator

As mentioned in the PR for adding PR template, a linter needs to be added to CI for Swift since Kotlin already has one.
@AquaGeek AquaGeek transferred this issue from square/workflow Jul 2, 2020
@watt watt mentioned this issue Nov 19, 2024
Merged
4 tasks
@watt watt closed this as completed in #316 Nov 20, 2024
watt added a commit that referenced this issue Nov 20, 2024
@watt
ci: lint with swiftformat (#316)
2ce9f82 
1. Adds a CI job that runs `swiftformat --lint` so that formatting is
enforced.
2. Updates the pre-commit hook to use
[git-format-staged](https://github.com/hallettj/git-format-staged) when
formatting.
3. Removes the SwiftPM dependency on SwiftFormat, preferring mise.
4. Formats everything.

Recommend reviewing by commit to see the changes that aren't formatting.

Fixes #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: lint with swiftformat square/workflow-swift
1 participant
@asthatrivedi