Combine Worker #104
Merged
Combine Worker #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
soorinpark
force-pushed
the
soorin/combineWorker
branch
from
1e59af3 to
9f0b8fc
Compare
soorinpark
force-pushed
the
soorin/combineWorker
branch
from
f1c1a20 to
ecf518d
Compare
Samples/WorkflowCombineSampleApp/WorkflowCombineSampleApp.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
Samples/WorkflowCombineSampleApp/WorkflowCombineSampleApp/Info.plist
Outdated
Show resolved
Hide resolved
...CombineSampleApp/WorkflowCombineSampleApp/Assets.xcassets/AccentColor.colorset/Contents.json
Outdated
Show resolved
Hide resolved
Samples/WorkflowCombineSampleApp/WorkflowCombineSampleApp/Base.lproj/LaunchScreen.storyboard
Outdated
Show resolved
Hide resolved
Samples/WorkflowCombineSampleApp/WorkflowCombineSampleApp/DemoWorker.swift
Outdated
Show resolved
Hide resolved
Samples/WorkflowCombineSampleApp/WorkflowCombineSampleApp/DemoWorker.swift
Outdated
Show resolved
Hide resolved
...owCombineSampleApp/WorkflowCombineSampleAppUnitTests/WorkflowCombineSampleAppUnitTests.swift
Outdated
Show resolved
Hide resolved
soorinpark
force-pushed
the
soorin/combineWorker
branch
2 times, most recently
from
6465719 to
eb089cc
Compare
soorinpark
force-pushed
the
soorin/combineWorker
branch
from
eb089cc to
2057460
Compare
soorinpark
commented
Nov 2, 2021
soorinpark
force-pushed
the
soorin/combineWorker
branch
2 times, most recently
from
21c91dd to
1f971a8
Compare
soorinpark
force-pushed
the
soorin/combineWorker
branch
from
1f971a8 to
07fd80a
Compare
Samples/WorkflowCombineSampleApp/WorkflowCombineSampleApp/ViewController.swift
Outdated
Show resolved
Hide resolved
| import Foundation | ||
| import Workflow | ||
|
|
||
| @available(iOS 13.0, macOS 10.15, *) |
There was a problem hiding this comment.
I wonder if we need these for each iOS 13+ API or if we can require iOS 13 at the library level. 🤔 cc: @amorde
soorinpark
force-pushed
the
soorin/combineWorker
branch
from
120f752 to
c4d4d10
Compare
dhavalshreyas
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist