Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a better name for flatMapWorkflow #320

Closed
zach-klippenstein opened this issue Apr 25, 2019 · 1 comment · Fixed by #377
Closed

Find a better name for flatMapWorkflow #320

zach-klippenstein opened this issue Apr 25, 2019 · 1 comment · Fixed by #377
Assignees
@zach-klippenstein
Labels
bug Something isn't working kotlin Affects the Kotlin library. obsolete Issues that have been closed because they are no longer relevant points: 1 question Further information is requested
Milestone
v1.0.0

Comments

@zach-klippenstein
Copy link
Collaborator

It's not a flatmap, it's more of a transform.

Also update #311.
@zach-klippenstein zach-klippenstein added bug Something isn't working points: 1 question Further information is requested labels Apr 25, 2019
@zach-klippenstein zach-klippenstein self-assigned this Apr 25, 2019
@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Apr 25, 2019
@zach-klippenstein
Copy link
Collaborator Author

collectMapWorkflow? Because it actually terminally "collects" everything from the source.

zach-klippenstein added a commit that referenced this issue May 30, 2019
@zach-klippenstein
Delete flatMapWorkflow.
bdf6ded 
`WorkflowRunnerViewModel` now uses `WorkflowHost` directly.

Closes #311 and closes #320 by making them obsolete.
@zach-klippenstein zach-klippenstein mentioned this issue May 30, 2019
Merged
@zach-klippenstein zach-klippenstein added the obsolete Issues that have been closed because they are no longer relevant label May 30, 2019
zach-klippenstein added a commit that referenced this issue May 30, 2019
@zach-klippenstein
Delete flatMapWorkflow.
769f298 
`WorkflowRunnerViewModel` now uses `WorkflowHost` directly.

Closes #311 and closes #320 by making them obsolete.
zach-klippenstein added a commit that referenced this issue May 30, 2019
@zach-klippenstein
Delete flatMapWorkflow.
2cdb310 
`WorkflowRunnerViewModel` now uses `WorkflowHost` directly.

Closes #311 and closes #320 by making them obsolete.
zach-klippenstein added a commit that referenced this issue May 31, 2019
@zach-klippenstein
Delete flatMapWorkflow.
6ba47d2 
`WorkflowRunnerViewModel` now uses `WorkflowHost` directly.

Closes #311 and closes #320 by making them obsolete.
zach-klippenstein added a commit that referenced this issue Jun 3, 2019
@zach-klippenstein
Delete flatMapWorkflow.
9420add 
`WorkflowRunnerViewModel` now uses `WorkflowHost` directly.

Closes #311 and closes #320 by making them obsolete.
@zach-klippenstein zach-klippenstein added the kotlin Affects the Kotlin library. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zach-klippenstein zach-klippenstein

Labels
bug Something isn't working kotlin Affects the Kotlin library. obsolete Issues that have been closed because they are no longer relevant points: 1 question Further information is requested
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Delete flatMapWorkflow square/workflow
1 participant
@zach-klippenstein