Moves StatelessWorkflow, Workflows.kt methods to Workflow. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlin/workflow-core/src/main/java/com/squareup/workflow/Workflow.kt
Outdated
Show resolved
Hide resolved
kotlin/workflow-core/src/main/java/com/squareup/workflow/Workflow.kt
Outdated
Show resolved
Hide resolved
kotlin/workflow-core/src/main/java/com/squareup/workflow/Workflow.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/move-factories
branch
from
a56652d
to
ca6a803
Compare
rjrjr
changed the title
rjrjr
force-pushed
the
ray/move-factories
branch
2 times, most recently
from
07c23e2
to
283676c
Compare
zach-klippenstein
approved these changes
Mar 28, 2019
kotlin/workflow-rx2/src/test/java/com/squareup/workflow/rx2/WorkflowContextsTest.kt
Show resolved
Hide resolved
kotlin/workflow-core/src/main/java/com/squareup/workflow/StatelessWorkflow.kt
Outdated
Show resolved
Hide resolved
rjrjr
changed the title
Hangs methods off extensions of Workflow.companion. Deletes Workflows.kt.
rjrjr
force-pushed
the
ray/move-factories
branch
from
283676c
to
4b03c8c
Compare
zach-klippenstein
approved these changes
Mar 28, 2019
|
|
|
Whatever, Travis. Passes locally, and the identical branch CI passed ages ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hangs methods off extensions of Workflow.companion.
Deletes Workflows.kt.