ClassDeclarationSniff bug with readonly classes

[enumag]

Describe the bug

The sniff removes a space and makes the code invalid

Code sample

final readonly class X implements Y {}

To reproduce

Steps to reproduce the behavior:

1. Create a file called test.php with the code sample above...
2. Run phpcs test.php ...
3. The sniff changes the code to

final readonlyclass X implements Y {}

Expected behavior

The code should be unchanged.

Versions (please complete the following information)

Operating System	debian
PHP version	8.2
PHP_CodeSniffer version	3.7.2
Standard	custom
Install type	composer

Please confirm:

• I have searched the issue list and am not opening a duplicate issue.
• I confirm that this bug is a bug in PHP_CodeSniffer and not in one of the external standards.
• I have verified the issue still exists in the master branch of PHP_CodeSniffer.

[fredden]

@enumag please can you confirm what sniff you think is causing issues? You have mentioned ClassDeclarationSniff, but there are four sniffs named that:

• PEAR.Classes.ClassDeclaration
• PSR1.Classes.ClassDeclaration
• PSR2.Classes.ClassDeclaration
• Squiz.Classes.ClassDeclaration

[enumag]

Oh I'm sorry, didn't realize there was more than one of them.

PHP_CodeSniffer\Standards\Squiz\Sniffs\Classes\ClassDeclarationSniff

[fredden]

@enumag thanks for confirming. When I run bin/phpcbf -sp --standard=Squiz --sniffs=Squiz.Classes.ClassDeclaration issue-3842.php with the suggested input, I get expected output. I suspect this may have already been fixed in 3f7b9ba / #3826.

[enumag]

Ah okay. It should work fine when 3.8.0 is released then. Thank you!