PHP 8.2 | Support readonly classes in 11 sniffs #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to token walk the contents of functions as the `final` keyword cannot be used in them anyway.
Includes improving the accuracy of the tokens to skip over. Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_classes
Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_classes
Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_classes
Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_classes
…ses/properties Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_properties_v2 * https://wiki.php.net/rfc/readonly_classes
Includes improving the accuracy of the tokens to skip over. Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_classes
Adjust existing unit test to confirm this is already handled correctly.
Includes unit test. Ref: * https://wiki.php.net/rfc/readonly_classes
3 tasks
10 tasks
|
FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release. As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up after PR #3686
PHP 8.2 | Generic/UnnecessaryFinalModifier: allow for readonly classes
Includes unit test.
Generic/UnnecessaryFinalModifier: make the sniff more efficient
No need to token walk the contents of functions as the
finalkeyword cannot be used in them anyway.PHP 8.2 | PEAR/ClassComment: allow for readonly classes
Includes improving the accuracy of the tokens to skip over.
Includes unit test.
PHP 8.2 | PEAR/FileComment: allow for readonly classes
Includes unit test.
PHP 8.2 | PSR2/ClassDeclaration: allow for readonly classes
Includes unit test.
PHP 8.2 | Squiz/ClassDeclaration: allow for readonly classes
Includes unit test.
PHP 8.2 | Squiz/LowercaseClassKeywords: add support for readonly classes/properties
Includes unit test.
Ref:
PHP 8.2 | Squiz/ClassComment: allow for readonly classes
Includes improving the accuracy of the tokens to skip over.
Includes unit test.
PHP 8.2 | Squiz/DocCommentAlignment: add test for readonly classes
Adjust existing unit test to confirm this is already handled correctly.
PHP 8.2 | Squiz/FileComment: allow for readonly classes
Includes unit test.
PHP 8.1/8.2 | Squiz/InlineComment: allow for readonly classes and properties
Includes unit test.
Suggested changelog entry
Support for
readonlyclasses has been added to the following sniffs:... list of the above named sniffs ....
Related issues/external references
Ref:
Types of changes