This repository has been archived by the owner on Nov 21, 2022. It is now read-only.
When searching by CRN, highlight course section found #14
Labels
Milestone
Comments
zacwood9
added
backend (Ruby)
enhancement
Nicholas-Thor-Page
pushed a commit
that referenced
this issue
Aug 25, 2020
Issue: #14 Fixed issue by doing the following: When processing a CRN, add a hash to the url so that when the course page is loaded, the section with the CRN will be jumped to. (app/controllers/search_controller.rb) Additionally, with CSS, highlight the target course with a green color (#afa) to signify that it is the desired course. (app/assets/stylesheets/application.scss) Turbolink messes with the behaviour of anchors, so when the page is loaded, a script makes sure that the hash is acted upon. (app/views/courses/show.html)
Merged
|
Looks like the css broke somewhere during all the merge conflict resolution. I'm going to try and fix this myself but for consistensy sake I'm going to reopen the issue Edit: to be specific, the course section is not highlighted anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If the user searches by CRN, they are brought to the course page the contains the section with the CRN. However, if there are many sections, it's not obvious which section was found by the query. Highlight the section card with that matched the query.
The text was updated successfully, but these errors were encountered: