Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chinese comment error #114

Closed
strivezsh opened this issue Nov 29, 2019 · 4 comments
Closed

chinese comment error #114

strivezsh opened this issue Nov 29, 2019 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@strivezsh
Copy link

zipFile.setComment("测试中文");
result:娴嬭瘯涓枃澶囨敞

net/lingala/zip4j/headers/HeaderWriter.java 599line
byte[] commentBytes = comment.getBytes(InternalZipConstants.CHARSET_UTF_8);
change
byte[] commentBytes = comment.getBytes("GBK");

Need to add configuration comment charset

@srikanth-lingala srikanth-lingala self-assigned this Nov 29, 2019
@srikanth-lingala srikanth-lingala added the bug Something isn't working label Nov 29, 2019
srikanth-lingala added a commit that referenced this issue Nov 29, 2019
@srikanth-lingala
Copy link
Owner

Issue fixed. Will include the fix in the next release.

@strivezsh
Copy link
Author

ok thanks

@srikanth-lingala
Copy link
Owner

Reopening the issue. I will close the issue after I make a release. It will help me keep track of the issues in a release.

@srikanth-lingala
Copy link
Owner

v2.2.7 released with the fix. It might take a few hours until the artefact is synced to maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants