Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZipParameters lastModifiedTime is ignored #434

Closed
NichtStudioCode opened this issue Jun 4, 2022 · 2 comments
Closed

ZipParameters lastModifiedTime is ignored #434

NichtStudioCode opened this issue Jun 4, 2022 · 2 comments
Assignees
@srikanth-lingala
Labels
bug Something isn't working resolved

Comments

@NichtStudioCode
Copy link

When adding a folder to a ZipFile using ZipFile#addFolder(File, ZipParameters) with ZipParameters#lastModifiedFileTime configured to some value such as 1, this value is ignored.

I believe that the reason for this behavior can be found here, as the lastModifiedFileTime just gets set to epochToExtendedDosTime((fileToAdd.lastModified())).
@NichtStudioCode NichtStudioCode changed the title ZipParameters lastModifiedTime is ignored when adding folder ZipParameters lastModifiedTime is ignored Jun 4, 2022
srikanth-lingala added a commit that referenced this issue Jun 20, 2022
@srikanth-lingala
#434 Use last modified file time from ZipParameters
3002b03
srikanth-lingala added a commit that referenced this issue Jun 20, 2022
@srikanth-lingala
#434 Use system time if last modified file time is not set
0f99010
@srikanth-lingala srikanth-lingala self-assigned this Jun 20, 2022
@srikanth-lingala srikanth-lingala added bug Something isn't working resolved labels Jun 20, 2022
@srikanth-lingala
Copy link
Owner

Issue fixed. I will include the fix in the next release.

@srikanth-lingala
Copy link
Owner

Fixed in v2.11.0 released today

@mintern mintern mentioned this issue Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srikanth-lingala srikanth-lingala

Labels
bug Something isn't working resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srikanth-lingala @NichtStudioCode