fix: left pad jaeger trace ids (open-telemetry#743)

srikanthccv · Feb 18, 2020 · d67cb8c · d67cb8c
1 parent 3d5879a
commit d67cb8c
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 2 deletions.
diff --git a/packages/opentelemetry-exporter-jaeger/src/transform.ts b/packages/opentelemetry-exporter-jaeger/src/transform.ts
@@ -40,8 +40,9 @@ const DEFAULT_FLAGS = 0x1;
  * @param span Span to be translated
  */
 export function spanToThrift(span: ReadableSpan): ThriftSpan {
-  const traceIdHigh = span.spanContext.traceId.slice(0, 16);
-  const traceIdLow = span.spanContext.traceId.slice(16);
+  const traceId = span.spanContext.traceId.padStart(32, '0');
+  const traceIdHigh = traceId.slice(0, 16);
+  const traceIdLow = traceId.slice(16);
   const parentSpan = span.parentSpanId
     ? Utils.encodeInt64(span.parentSpanId)
     : ThriftUtils.emptyBuffer;

diff --git a/packages/opentelemetry-exporter-jaeger/test/transform.test.ts b/packages/opentelemetry-exporter-jaeger/test/transform.test.ts
@@ -219,5 +219,37 @@ describe('transform', () => {
       assert.strictEqual(ref1.spanId.toString('hex'), '3e0c63257de34c92');
       assert.strictEqual(ref1.refType, ThriftReferenceType.CHILD_OF);
     });
+
+    it('should left pad trace ids', () => {
+      const readableSpan: ReadableSpan = {
+        name: 'my-span1',
+        kind: types.SpanKind.CLIENT,
+        spanContext: {
+          traceId: '92b449d5929fda1b',
+          spanId: '6e0c63257de34c92',
+        },
+        startTime: [1566156729, 709],
+        endTime: [1566156731, 709],
+        status: {
+          code: types.CanonicalCode.DATA_LOSS,
+          message: 'data loss',
+        },
+        attributes: {},
+        links: [],
+        events: [],
+        duration: [32, 800000000],
+      };
+
+      const thriftSpan = spanToThrift(readableSpan);
+
+      assert.strictEqual(
+        thriftSpan.traceIdLow.toString('hex'),
+        '92b449d5929fda1b'
+      );
+      assert.strictEqual(
+        thriftSpan.traceIdHigh.toString('hex'),
+        '0000000000000000'
+      );
+    });
   });
 });