Provide functions to check bounds for the input provided. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 185
💛 - Coveralls |
srishanbhattarai
requested changes
Jan 1, 2020
cli.go
Outdated
| @@ -35,6 +35,11 @@ func (nepcalCli) convADToBS(c *cli.Context) { | |||
|
|
|||
| mm, dd, yy, _ := parseRawDate(c.Args().First()) | |||
| adDate := toTime(yy, time.Month(mm), dd) | |||
| if err := dateconv.CheckBoundsAD(adDate); err != nil { | |||
| fmt.Println(err) | |||
There was a problem hiding this comment.
write to stderr
- fmt.Println(err)
+ fmt.Fprintln(os.Stderr, err)
cli.go
Outdated
| @@ -48,6 +53,12 @@ func (nepcalCli) convBSToAD(c *cli.Context) { | |||
| } | |||
|
|
|||
| mm, dd, yy, _ := parseRawDate(c.Args().First()) | |||
| bsdate := dateconv.NewBSDate(yy, mm, dd) | |||
| if err := bsdate.CheckBounds(); err != nil { | |||
| fmt.Println(err) | |||
| @@ -47,6 +47,30 @@ func (b BSDate) After(u BSDate) bool { | |||
| return dateA > dateB | |||
| } | |||
|
|
|||
| // CheckBounds checks if the conversion is possible. Raises an error is an out | |||
| // of bound input is provided. Date after 2000 Baisakh 1 should be provided. | |||
| func (b BSDate) CheckBounds() error { | |||
There was a problem hiding this comment.
Please add some tests for these, would rather merge these in with some (trivial) tests even though they are pretty simple.
Instead of panicking in the user facing interface for invalid date. Log an error instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of panicking in the user facing interface for invalid date. Log an error instead.