Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline #2213 #2218

Merged
merged 1 commit into from
Oct 4, 2024
Merged

streamline #2213 #2218

merged 1 commit into from
Oct 4, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Oct 4, 2024

No description provided.

@steiler steiler requested a review from hellt October 4, 2024 08:12
@hellt
Copy link
Member

hellt commented Oct 4, 2024

looks good, ty!

@hellt hellt merged commit d9b0cf7 into srl-labs:main Oct 4, 2024
62 of 63 checks passed
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.17%. Comparing base (fbca124) to head (1f0f4b9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
links/link_vxlan.go 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
- Coverage   51.22%   51.17%   -0.05%     
==========================================
  Files         170      170              
  Lines       12495    12489       -6     
==========================================
- Hits         6400     6391       -9     
- Misses       5196     5199       +3     
  Partials      899      899              
Files with missing lines Coverage Δ
cmd/vxlan.go 64.28% <100.00%> (ø)
links/link_vxlan_stitched.go 65.43% <100.00%> (ø)
links/link_vxlan.go 66.90% <16.66%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants