Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Config class #39

Closed
hhkim0729 opened this issue Oct 19, 2022 · 1 comment · Fixed by #60
Closed

Apply Config class #39

hhkim0729 opened this issue Oct 19, 2022 · 1 comment · Fixed by #60
Assignees
@hhkim0729 @S0YKIM @srngch
Labels
feature New feature or request

Comments

@hhkim0729
Copy link
Collaborator

  • Config 클래스 도입
@hhkim0729 hhkim0729 added the feature New feature or request label Oct 19, 2022
@S0YKIM S0YKIM self-assigned this Oct 19, 2022
@srngch
Copy link
Owner

srngch commented Oct 21, 2022

conf에 에러 페이지가 정의되어 있다면, HttpException 클래스의 makeHtml 메소드에서 불러오기

hhkim0729 added a commit that referenced this issue Oct 24, 2022
@hhkim0729 @S0YKIM
feat: Apply Config class(#39)
d7a66e1 
Apply Config class to Cgi, Uri, Worker classes

Additional tasks
- Modify conf files
- Fix validating config file when there's no semicolon at the end of the line
- Delete WEB_ROOT from macro.hpp
- Fix getLocationBlock() to return the location block which has the most similar URI

Co-authored-by: Soyeon Kim <eden.sy.kim@gmail.com>
@hhkim0729 hhkim0729 mentioned this issue Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hhkim0729 hhkim0729

@S0YKIM S0YKIM

@srngch srngch

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply Config class srngch/ngin-xs
3 participants
@hhkim0729 @S0YKIM @srngch