feat: Handle chunked request(#13) #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional tasks - Change Request param of constructor(header) - Add setBody() in Request class - Add 501 not implemented exception - Add hexStringToNumber() util - Separate method handling logic to member functions - Fix issue when request message is bigger than buffer size Co-authored-by: srngch <srngch.dev@gmail.com>
hhkim0729
added
bug
S0YKIM
approved these changes
Oct 14, 2022
| std::map<std::string, std::string>::iterator it = headers_.find(fieldName); | ||
| if (it == headers_.end()) | ||
| throw std::invalid_argument("Field name " + fieldName + " does not exist"); | ||
| return std::string(""); |
There was a problem hiding this comment.
왜 예외를 던지지 않고 빈 문자열을 반환하도록 변경되었나요?
There was a problem hiding this comment.
어차피 클라이언트에서 헤더 필드만 보내고 밸류가 없는 것도 잘못된 헤더였기 때문에
헤더가 없는 경우 + 헤더의 밸류가 없는 경우 모두 같은 것으로 취급하기로 했습니다~!
👉 이 함수를 사용하는 곳에서 예외처리를 해야 하는 수고를 더는 효과를 얻었습니다~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
리뷰어에게
많은 변화가.... 커밋 메시지 참고 요망